Skip to content

feat: use custom html builder for widget3#7467

Draft
Rathoz wants to merge 3 commits intomainfrom
widget3-custom-html
Draft

feat: use custom html builder for widget3#7467
Rathoz wants to merge 3 commits intomainfrom
widget3-custom-html

Conversation

@Rathoz
Copy link
Copy Markdown
Collaborator

@Rathoz Rathoz commented May 6, 2026

Summary

TODO: Test performance

How did you test this change?

Comment thread lua/wikis/commons/Widget/Renderer.lua Outdated

if props.attributes then
for k, v in pairs(props.attributes) do
if type(v) == 'boolean' then
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we maybe want to disallow class and style as attributes?
(to prevent missusage)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meh neh it's okay

Base automatically changed from widget30 to main May 7, 2026 08:56
@Rathoz Rathoz force-pushed the widget3-custom-html branch from 637c48e to 0abfab5 Compare May 7, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants